Skip to content

[SYCL][Graph] Update design doc for copy optimization and add test #13051

Merged
steffenlarsen merged 2 commits intointel:syclfrom
reble:maxime/update-doc-copy-queue
Jun 14, 2024
Merged

[SYCL][Graph] Update design doc for copy optimization and add test #13051
steffenlarsen merged 2 commits intointel:syclfrom
reble:maxime/update-doc-copy-queue

Conversation

@mfrancepillois
Copy link

@mfrancepillois mfrancepillois commented Mar 18, 2024

  • Update UR tag to include L0 command-buffer copy engine optimization
  • Add test which mixes copy and kernel commands
  • Update design doc to detail copy engine optimization

Co-authored By:

@Bensuo Bensuo force-pushed the maxime/update-doc-copy-queue branch from 9a9dc4f to da3103b Compare May 27, 2024 16:31
@Bensuo Bensuo temporarily deployed to WindowsCILock May 27, 2024 16:38 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock May 28, 2024 11:46 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the maxime/update-doc-copy-queue branch from 7739b83 to d5773eb Compare May 28, 2024 14:49
@Bensuo Bensuo temporarily deployed to WindowsCILock May 28, 2024 15:09 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the maxime/update-doc-copy-queue branch from 73ba45c to 4a47e54 Compare June 4, 2024 16:21
@Bensuo Bensuo temporarily deployed to WindowsCILock June 4, 2024 16:33 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock June 4, 2024 17:46 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the maxime/update-doc-copy-queue branch from 604d581 to eb67857 Compare June 10, 2024 13:39
@Bensuo Bensuo temporarily deployed to WindowsCILock June 10, 2024 13:39 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock June 10, 2024 14:04 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the maxime/update-doc-copy-queue branch from eb67857 to 020a5ff Compare June 11, 2024 16:41
@EwanC EwanC force-pushed the maxime/update-doc-copy-queue branch from 020a5ff to 0d13b58 Compare June 14, 2024 07:43
@EwanC EwanC temporarily deployed to WindowsCILock June 14, 2024 07:43 — with GitHub Actions Inactive
@EwanC EwanC changed the title [SYCL][Graph] Update design doc for copy queue [SYCL][Graph] Update design doc for copy optimization and add test Jun 14, 2024
@EwanC EwanC temporarily deployed to WindowsCILock June 14, 2024 08:09 — with GitHub Actions Inactive
@EwanC EwanC marked this pull request as ready for review June 14, 2024 09:51
@EwanC EwanC requested review from a team as code owners June 14, 2024 09:51
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR tag will need updated once PR is merged, but graph changes LGTM

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneapi-src/unified-runtime#1738 has been merged, please pull in the latest sycl branch changes and update the UR repo/tag as suggested.

Maxime France-Pillois and others added 2 commits June 14, 2024 14:30
- Update UR tag to include L0 command-buffer copy engine optimization
- Add test which mixes copy and kernel commands
- Update design doc to detail copy engine optimization
Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
@EwanC EwanC force-pushed the maxime/update-doc-copy-queue branch from 5d44bdf to 01b1582 Compare June 14, 2024 13:30
@EwanC EwanC temporarily deployed to WindowsCILock June 14, 2024 13:30 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock June 14, 2024 13:55 — with GitHub Actions Inactive
@kbenzie
Copy link
Contributor

kbenzie commented Jun 14, 2024

@intel/llvm-gatekeepers please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants